<div dir="ltr">For tx reject, should there be a code for "unknown version"? That is, tx.nVersion > bestKnownVersion == reject? In that case 0x40 would become "non-standard transaction type". I think "unknown transaction type" is a bit vague. Or do we want new tx messages to always be backwards compatible?<div>
<br></div><div>0x42 and 0x43 seems a bit similar to me. The sender knows what fee was paid (presumably). If free transactions and fee-paying transactions end up having a unified ranking applied, then distinguishing between them in the reject message won't make much sense.</div>
<div><br></div><div>For block 0x11 again shall there be a separate code for "block is from the future"? We don't want to lose the nVersion field to people just using it for nonsense, so does it make sense to reject blocks that claim to be v2 or v3?</div>
<div><br></div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Oct 29, 2013 at 6:37 AM, Gavin Andresen <span dir="ltr"><<a href="mailto:gavinandresen@gmail.com" target="_blank">gavinandresen@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><br></div>Thanks for the feedback, everybody, gist updated:<div> <a href="https://gist.github.com/gavinandresen/7079034" target="_blank">https://gist.github.com/gavinandresen/7079034</a></div>
<div><br></div><div>Categories are:</div>
<div><br></div><div><table style="line-height:25px;border-spacing:0px;border-collapse:collapse;overflow:auto;width:724px;font-size:15px;font-family:Helvetica,arial,freesans,clean,sans-serif;display:block;margin:15px 0px">
<tbody><tr style="border-top-width:1px;border-top-style:solid;border-top-color:rgb(204,204,204);background-color:rgb(248,248,248)"><td style="border:1px solid rgb(221,221,221);padding:6px 13px">0x01-0x0f</td><td style="border:1px solid rgb(221,221,221);padding:6px 13px">
Protocol syntax errors</td></tr><tr style="border-top-width:1px;border-top-style:solid;border-top-color:rgb(204,204,204)"><td style="border:1px solid rgb(221,221,221);padding:6px 13px">0x10-0x1f</td><td style="border:1px solid rgb(221,221,221);padding:6px 13px">
Protocol semantic errors</td></tr><tr style="border-top-width:1px;border-top-style:solid;border-top-color:rgb(204,204,204);background-color:rgb(248,248,248)"><td style="border:1px solid rgb(221,221,221);padding:6px 13px">
0x40-0x4f</td><td style="border:1px solid rgb(221,221,221);padding:6px 13px">Server policy rule<br></td></tr></tbody></table><h4 style="line-height:1.7;font-size:1.2em;font-family:Helvetica,arial,freesans,clean,sans-serif;margin:1em 0px 15px;padding:0px">
<a name="14202b7cb90c3677_rejection-codes-common-to-all-message-types" href="https://gist.github.com/gavinandresen/7079034#rejection-codes-common-to-all-message-types" style="color:rgb(65,131,196);text-decoration:none;display:block;padding-left:30px" target="_blank"><span></span></a></h4>
</div><div class="gmail_extra"><br></div><div class="gmail_extra">RE: why not a varint: because we're never ever going to run out of reject codes. Eight are defined right now, if we ever defined eight more I'd be surprised.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">RE: why not use HTTP codes directly: because we'd be fitting round pegs into square holes.<span class="HOEnZb"><font color="#888888"><br><br>-- <br>--<br>Gavin Andresen<br>
</font></span></div></div>
<br>------------------------------------------------------------------------------<br>
Android is increasing in popularity, but the open development platform that<br>
developers love is also attractive to malware creators. Download this white<br>
paper to learn more about secure code signing practices that can help keep<br>
Android apps secure.<br>
<a href="http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk" target="_blank">http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk</a><br>_______________________________________________<br>
Bitcoin-development mailing list<br>
<a href="mailto:Bitcoin-development@lists.sourceforge.net">Bitcoin-development@lists.sourceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/bitcoin-development" target="_blank">https://lists.sourceforge.net/lists/listinfo/bitcoin-development</a><br>
<br></blockquote></div><br></div>