<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-15">
<META NAME="Generator" CONTENT="MS Exchange Server version 6.5.7651.59">
<TITLE>Re: [PATCH] net, bridge: print log message after state changed</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->
<BR>
<P><FONT SIZE=2>Am Montag, den 14.11.2011, 00:37 -0500 schrieb David Miller:<BR>
> From: Holger Brunck <holger.brunck@keymile.com><BR>
> Date: Thu, 10 Nov 2011 17:18:54 +0100<BR>
><BR>
> > From: Wolfgang Fritz <wolfgang.fritz@keymile.com><BR>
> ><BR>
> > Function br_log_state writes log message "... entering XXXX state" so it<BR>
> > should be called after the state has changed and not before.<BR>
> ><BR>
> > Signed-off-by: Wolfgang Fritz <wolfgang.fritz@keymile.com><BR>
> > Signed-off-by: Holger Brunck <holger.brunck@keymile.com><BR>
><BR>
> "entering" can roughly mean "about to enter"<BR>
><BR>
<BR>
Exactly.<BR>
<BR>
> The message is therefore appropriately timed as far as I'm concerned.<BR>
><BR>
<BR>
It's not.<BR>
<BR>
Please test: create a bridge with STP disabled, add an interface to the<BR>
bridge and set that interface down. You get the message "... entering<BR>
forwarding state". That's wrong because it's "about to enter" disabled<BR>
state some lines later.<BR>
<BR>
All other (4) calls to br_log_state are located after the state change,<BR>
see for example br_stp_enable_port() just some lines above the patch.<BR>
<BR>
Regards,<BR>
Wolfgang<BR>
<BR>
<BR>
> I'm not applying this patch.<BR>
><BR>
--<BR>
"I love deadlines. I like the whooshing sound they make as they fly by"<BR>
(Douglas Adams)<BR>
=======================================================================<BR>
KEYMILE GmbH <A HREF="mailto:wolfgang.fritz@keymile.com">mailto:wolfgang.fritz@keymile.com</A><BR>
Wolfgang Fritz Phone: +49 (0)511 6747-692<BR>
Wohlenbergstr. 3 Fax: +49 (0)511 6747-777<BR>
D-30179 Hannover <A HREF="http://www.keymile.com">http://www.keymile.com</A><BR>
<BR>
Managing Directors: Björn Claaßen, Dipl.-Kfm. Andreas Gebauer<BR>
Legal structure: GmbH, Registered office: Hanover, HRB 61069<BR>
Local court Hanover, VAT-Reg.-No.: DE 812282795,<BR>
WEEE-Reg.-No.: DE 59336750<BR>
</FONT>
</P>
</BODY>
</HTML>