[Bugme-janitors] [Bug 9575] NULL pointer dereference on kernel/auditsc.c

bugme-daemon at bugzilla.kernel.org bugme-daemon at bugzilla.kernel.org
Thu Dec 20 11:53:37 PST 2007


http://bugzilla.kernel.org/show_bug.cgi?id=9575


eparis at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eparis at redhat.com




------- Comment #2 from eparis at redhat.com  2007-12-20 11:53 -------
Your line numbers don't match up with any kernel I can find so I'm going
ENTIRELY on where I see if(!ctx->target_pid) which is inside
__audit_signal_info().  Assuming I'm looking at the right function you are
right about there being needless extra checks for if(ctx) because the only
caller to __audit_signal_info is:

kernel/audit.h::audit_signal_info()

which includes a check for !audit_dummy_context() which really does nothing but
check if current has a valid audit_context.

since we can never get into __audit_signal_info with current->audit_context ==
NULL all of the checks inside for NULL are needless and a waste of time, but
this doesn't appear to be a NULL pointer dereference to me.


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


More information about the Bugme-janitors mailing list