[Bugme-new] [Bug 40482] New: Synchronic's line disciplines(ppp_synctty, hdlc) can't work with pseudo terminals.

bugzilla-daemon at bugzilla.kernel.org bugzilla-daemon at bugzilla.kernel.org
Wed Aug 3 10:50:49 PDT 2011


https://bugzilla.kernel.org/show_bug.cgi?id=40482

           Summary: Synchronic's line disciplines(ppp_synctty, hdlc) can't
                    work with pseudo terminals.
           Product: Drivers
           Version: 2.5
    Kernel Version: 2.6.31-rc5+
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: high
          Priority: P1
         Component: Other
        AssignedTo: drivers_other at kernel-bugs.osdl.org
        ReportedBy: utdilya at mail.ru
        Regression: Yes


Created an attachment (id=67422)
 --> (https://bugzilla.kernel.org/attachment.cgi?id=67422)
pty_set_low_latency.patch

If frames send very fast from one side(master/slave) to other one,
frames merge in one (merge point "flip buffer") and the other side can read
only one big frame. But sync line discipline need one frame in one read.

For push one frame to ldisc I propose small patch, but this regression for
commit e043e42bdb66885b3ac10d27a01ccb9972e2b0a3.

I don't find any mutexes in function flush_to_ldisc(), and I think this patch
is true and this function can calling from any context. But I not sure.

Relative commit  86d23a057e718f73adc15e463c643d6e014a19cd.


--- orig/pty.c    2011-07-13 07:29:43.000000000 +0400
+++ work/pty.c    2011-08-03 20:59:01.000000000 +0400
@@ -204,6 +204,7 @@
     clear_bit(TTY_OTHER_CLOSED, &tty->link->flags);
     set_bit(TTY_THROTTLED, &tty->flags);
     retval = 0;
+    tty->low_latency = 1;
 out:
     return retval;
 }

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the Bugme-new mailing list