[PATCH 2/2] Explicitly set pgid and sid of init

Eric W. Biederman ebiederm at xmission.com
Thu Feb 22 22:17:45 PST 2007


Dave Hansen <hansendc at us.ibm.com> writes:

> On Thu, 2007-02-22 at 15:24 -0800, sukadev at us.ibm.com wrote:
>> -       if (process_group(curr) != pgrp) {
>> +       if (pid_nr(task_pgrp(curr)) != pgrp) { 
>
> I wonder if there are enough of these cases to start doing:
>
> 	#define task_pgrp_nr(tsk)  pid_nr(task_pgrp(tsk))
> 	#define task_tgid_nr(tsk)  pid_nr(task_tgid(tsk))

There shouldn't be.  We should really fix the arguments of __set_special_pids
to be struct_pid *.  At which point this ugliness goes away.

Eric



More information about the Containers mailing list