[patch 07/22] ext4: remove extra IS_RDONLY() check

Cedric Le Goater clg at fr.ibm.com
Thu Jun 7 08:25:34 PDT 2007


From: Dave Hansen <hansendc at us.ibm.com>

ext4_change_inode_journal_flag() is only called from one
location: ext4_ioctl(EXT3_IOC_SETFLAGS).  That ioctl
case already has a IS_RDONLY() call in it so this one
is superfluous.

Signed-off-by: Dave Hansen <hansendc at us.ibm.com>
---

---
 fs/ext4/inode.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: 2.6.22-rc4-mm2-robindmount/fs/ext4/inode.c
===================================================================
--- 2.6.22-rc4-mm2-robindmount.orig/fs/ext4/inode.c
+++ 2.6.22-rc4-mm2-robindmount/fs/ext4/inode.c
@@ -3359,7 +3359,7 @@ int ext4_change_inode_journal_flag(struc
 	 */
 
 	journal = EXT4_JOURNAL(inode);
-	if (is_journal_aborted(journal) || IS_RDONLY(inode))
+	if (is_journal_aborted(journal))
 		return -EROFS;
 
 	jbd2_journal_lock_updates(journal);

-- 


More information about the Containers mailing list