[PATCH 1/1] implement s390 clone_with_pids syscall
Nathan Lynch
nathanl at austin.ibm.com
Tue Nov 10 23:27:22 PST 2009
> + parent_tid_ptr = (int *)kca.parent_tid_ptr;
> + child_tid_ptr = (int *)kca.child_tid_ptr;
> +
> + stack_size = (unsigned long)kca.child_stack_size;
> + child_stack = (unsigned long)kca.child_stack_base;
> + if (child_stack)
> + child_stack += stack_size;
Should this calculation not be of the form:
child_stack = arch_dependent_alignment(child_stack + stack_size - 1)
?
Is overflow a concern?
Same questions apply to the x86 version.
More information about the Containers
mailing list