<div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 19, 2018 at 10:18 PM, <span dir="ltr"><<a href="mailto:Tim.Bird@sony.com" target="_blank">Tim.Bird@sony.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-"><br>
<br>
> -----Original Message-----<br>
> From: Guilherme Campos Camargo<br>
> Those directories ideally shoud be copied to the image during build time<br>
> given that Fuego would not run if their content is not available. By<br>
> doing this, we're also making sure that a user that plans to use<br>
> fuego-base docker image directly (or as a base image for his own docker<br>
> images) will be able to do it straightforwardly, without the need of<br>
> cloning other repositories or bind-mounting host's directories.<br>
><br>
> It's also a good idea to keep fuego-core locked in a fixed release, what<br>
> we can enforce easily by using git submodules. This is desired if we<br>
> want to use a stable version of fuego to test new versions of fuego.<br>
><br>
> On this patch we configure fuego-core as a submodule and make the<br>
> changes needed for copying the required contents of the mentioned<br>
> directories.<br>
<br>
</span>I understand virtually none of what you wrote here.<br>
<br>
Is this patch for tbird20d/fuego? Is it against profusionmobil/fuego-release-<wbr>test?<br></blockquote><div><br></div><div class="gmail_default" style="font-family:monospace,monospace">This patch is for tbird20d/fuego.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
I haven't figured out how the fuego-release-test works yet, so I don't<br>
understand what you're referring to when you say "those directories",<br>
or "fuego-base docker image".<br></blockquote><div><br></div><div class="gmail_default" style="font-family:monospace,monospace">Sorry about that.</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">On profusionmobi/fuego-release-test Dockerfile, I'm using a stable</div><div class="gmail_default" style="font-family:monospace,monospace">fuego image as base, with the following directive:</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">FROM fuegotest/fuego-base:latest</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">fuegotest/fuego-base image has been created from tbird20d/fuego:next - with</div><div class="gmail_default" style="font-family:monospace,monospace">the patch of this e-mail applied - and uploaded to</div><div class="gmail_default" style="font-family:monospace,monospace"><a href="https://hub.docker.com/r/fuegotest/fuego-base/">https://hub.docker.com/r/fuegotest/fuego-base/</a></div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">For fuego-release-test to work as presented (in my other e-mail), we need to</div><div class="gmail_default" style="font-family:monospace,monospace">have fuego-core and fuego-base as part of the base image (fuegotest/fuego-base).</div><div class="gmail_default" style="font-family:monospace,monospace">This patch just copies fuego-base and fuego-core to the fuego image during</div><div class="gmail_default" style="font-family:monospace,monospace">build time. Since fuego-core is in a separate repository, I'm just moving it it inside</div><div class="gmail_default" style="font-family:monospace,monospace">fuego as a submodule.</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace"></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class="gmail-"><br>
><br>
> --<br>
> Tim, please let us know what you think about it.<br>
</span>I need to understand what's going on, and how all these repositories<br>
interact, before I can give any coherent answer.<br>
<br>
I think that once I've run the release test successfully, I will be able<br>
to figure out what you're talking about here.<br>
-- Tim<br>
<br>
<br>
</blockquote></div><br></div></div>