<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jan 7, 2020 at 11:56 PM Jason Gunthorpe <<a href="mailto:jgg@ziepe.ca">jgg@ziepe.ca</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, Jan 07, 2020 at 11:05:08PM +0530, <a href="mailto:madhuparnabhowmik04@gmail.com" target="_blank">madhuparnabhowmik04@gmail.com</a> wrote:<br>
> From: Madhuparna Bhowmik <<a href="mailto:madhuparnabhowmik04@gmail.com" target="_blank">madhuparnabhowmik04@gmail.com</a>><br>
> <br>
> list_for_each_entry_rcu has built-in RCU and lock checking.<br>
> Pass cond argument to list_for_each_entry_rcu.<br>
> <br>
> Signed-off-by: Madhuparna Bhowmik <<a href="mailto:madhuparnabhowmik04@gmail.com" target="_blank">madhuparnabhowmik04@gmail.com</a>><br>
>  drivers/infiniband/hw/hfi1/verbs.c | 3 ++-<br>
>  1 file changed, 2 insertions(+), 1 deletion(-)<br>
> <br>
> diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c<br>
> index 089e201d7550..cab2ff185240 100644<br>
> +++ b/drivers/infiniband/hw/hfi1/verbs.c<br>
> @@ -515,7 +515,8 @@ static inline void hfi1_handle_packet(struct hfi1_packet *packet,<br>
>                                      opa_get_lid(packet->dlid, 9B));<br>
>               if (!mcast)<br>
>                       goto drop;<br>
> -             list_for_each_entry_rcu(p, &mcast->qp_list, list) {<br>
> +             list_for_each_entry_rcu(p, &mcast->qp_list, list<br>
> +                                                             lock_is_held(&(ibp->rvp.lock).dep_map)) {<br>
<br>
This is missing a ',' and isn't indented properly. Does it even<br>
compile?<br>
<br></blockquote><div>I am really sorry about this, I will resend this patch.</div><div>Yes, it compiles, though I guess after testing I edited it by mistake.</div><div><br></div><div>Thanks,</div><div>Madhuparna</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
The idea seems sound though.<br>
<br>
Jason<br>
</blockquote></div></div><div hspace="streak-pt-mark" style="max-height:1px"><img alt="" style="width:0px;max-height:0px;overflow:hidden" src="https://mailfoogae.appspot.com/t?sender=abWFkaHVwYXJuYWJob3dtaWswNEBnbWFpbC5jb20%3D&type=zerocontent&guid=1d0a4aad-2a9e-4301-b60e-98b484865aa5"><font color="#ffffff" size="1">ᐧ</font></div>