<br><br>On Monday, July 20, 2020, Nachiket N <<a href="mailto:nachiketun8@gmail.com">nachiketun8@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>I did run checkpatch on the patch in the previous mail.</div><div>Checkpatch.pl outputs warnings for commit description lines that exceed<br>beyond 75 chars. Sometimes these lines might contain signature tags that cannot be<br>shortened. The patch checks if the line has any valid signature tags and disables<br>the warning in such a case.</div><div>I tested it on patches which contain long commit log lines such as</div><div>Reported-and-tested-by: <a href="mailto:syzbot%2Bdb339689b2101f6f6071@syzkaller.appspotmail.com" target="_blank">syzbot+db339689b2101f6f6071@<wbr>syzkaller.appspotmail.com</a></div><div>in patch generated by commit ID ac854131d984.</div><div>It does not output commit warning for in such cases.</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br></blockquote></blockquote><div><br></div><div>Okay, this patch below is not ready for submission to the general mailing list.</div><div><br></div><div>Please read the kernel documentation on proper preparation of a patch submission.</div><div><br></div><div>Lukas</div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Jul 19, 2020 at 11:07 PM Lukas Bulwahn <<a href="mailto:lukas.bulwahn@gmail.com" target="_blank">lukas.bulwahn@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div dir="auto">Did you checkpatch this patch?</div></div><div dir="auto"><br></div><div dir="auto">You need to provide a rationale. Use a full <a href="http://checkpatch.pl" target="_blank">checkpatch.pl</a> evaluation data for showing the difference before and after applying the patch.</div><div dir="auto"><br></div><div dir="auto">Lukas</div><div><br><div class="gmail_quote"><div>On So., 19. Juli 2020 at 19:16, Nachiket Naganure <<a href="mailto:nachiketun8@gmail.com" target="_blank">nachiketun8@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">From: NachiketUN <<a href="mailto:nachiketun8@gmail.com" target="_blank">nachiketun8@gmail.com</a>><br>
<br>
Signed-off-by: NachiketUN <<a href="mailto:nachiketun8@gmail.com" target="_blank">nachiketun8@gmail.com</a>><br>
---<br>
scripts/<a href="http://checkpatch.pl" rel="noreferrer" target="_blank">checkpatch.pl</a> | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/scripts/<a href="http://checkpatch.pl" rel="noreferrer" target="_blank">checkpatch.pl</a> b/scripts/<a href="http://checkpatch.pl" rel="noreferrer" target="_blank">checkpatch.pl</a><br>
index 197436b20288..8db0f26601c5 100755<br>
--- a/scripts/<a href="http://checkpatch.pl" rel="noreferrer" target="_blank">checkpatch.pl</a><br>
+++ b/scripts/<a href="http://checkpatch.pl" rel="noreferrer" target="_blank">checkpatch.pl</a><br>
@@ -2799,7 +2799,7 @@ sub process {<br>
<br>
# Check for line lengths > 75 in commit log, warn once<br>
if ($in_commit_log && !$commit_log_long_line &&<br>
- length($line) > 75 &&<br>
+ length($line) > 75 && $line !~ /$signature_tags/ &&<br>
!($line =~ /^\s*[a-zA-Z0-9_\/\.]+\s+\|\s+<wbr>\d+/ ||<br>
# file delta changes<br>
$line =~ /^\s*(?:[\w\.\-]+\/)++[\w\.\-]<wbr>+:/ ||<br>
-- <br>
2.25.1<br>
<br>
</blockquote></div></div>
</blockquote></div>
</blockquote>