<div><br></div><div><br><div class="gmail_quote"><div dir="auto">On Fr., 20. Nov. 2020 at 21:03, Aditya <<a href="mailto:yashsri421@gmail.com">yashsri421@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 21/11/20 1:28 am, Aditya Srivastava wrote:<br>
> Checkpatch.pl warns on non-standard signature styles.<br>
> <br>
> E.g., running checkpatch on commit 513f7f747e1c ("parisc: Fix vmap<br>
> memory leak in ioremap()/iounmap()") reports this warning:<br>
> <br>
> WARNING: Non-standard signature: Noticed-by:<br>
> Noticed-by: Sven Schnelle <<a href="mailto:svens@stackframe.org" target="_blank">svens@stackframe.org</a>><br>
></blockquote><div dir="auto"><br></div><div dir="auto">This example really does not tell anyone much.</div><div dir="auto"><br></div><div dir="auto">Replace it with a summary from your evaluation.</div><div dir="auto"><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br>
> Provide a fix by:<br>
> 1) replacing the non-standard signature with its standard equivalent<br>
> 2) removing the signature if it is not required<br>
> <br>
> Also, improve warning messages correspondingly, providing users<br>
> suggestions to either replace or remove the signature<br>
> </blockquote><div dir="auto"><br></div><div dir="auto">Looks good.</div><div dir="auto"><br></div><div dir="auto"><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
> Signed-off-by: Aditya Srivastava <<a href="mailto:yashsri421@gmail.com" target="_blank">yashsri421@gmail.com</a>><br>
> ---<br>
>  scripts/<a href="http://checkpatch.pl" rel="noreferrer" target="_blank">checkpatch.pl</a> | 45 +++++++++++++++++++++++++++++++++++++++++--<br>
>  1 file changed, 43 insertions(+), 2 deletions(-)<br>
> <br>
> diff --git a/scripts/<a href="http://checkpatch.pl" rel="noreferrer" target="_blank">checkpatch.pl</a> b/scripts/<a href="http://checkpatch.pl" rel="noreferrer" target="_blank">checkpatch.pl</a><br>
> index fdfd5ec09be6..23a21dc2c29a 100755<br>
> --- a/scripts/<a href="http://checkpatch.pl" rel="noreferrer" target="_blank">checkpatch.pl</a><br>
> +++ b/scripts/<a href="http://checkpatch.pl" rel="noreferrer" target="_blank">checkpatch.pl</a><br>
> @@ -506,6 +506,27 @@ our $signature_tags = qr{(?xi:<br>
>       Cc:<br>
>  )};<br>
>  <br>
> +our %standard_signature_fix = (<br>
> +     "Requested-by:" => "Suggested-by:",<br>
> +     "Co-authored-by:" => "Co-developed-by:",<br>
> +     "Analyzed-by:" => "Co-developed-by:",<br>
> +     "Analysed-by:" => "Co-developed-by:",<br>
> +     "Improvements-by:" => "Co-developed-by:",<br>
> +     "Noticed-by:" => "Reported-by:",<br>
> +     "Inspired-by:" => "Suggested-by:",<br>
> +     "Verified-by:" => "Tested-by:",<br>
> +     "Okay-ished-by:" => "Acked-by:",<br>
> +     "Acked-for-MFD-by:" => "Acked-by:",<br>
> +     "Reviewed-off-by:" => "Reviewed-by:",<br>
> +     "Proposed-by:" => "Suggested-by:",<br>
> +     "Fixed-by:" => "Co-developed-by:",<br>
> +     "Pointed-out-by:" => "Suggested-by:",<br>
> +     "Pointed-at-by:" => "Suggested-by:",<br>
> +     "Suggestions-by:" => "Suggested-by:",<br>
> +     "Generated-by:" => "remove",<br>
> +     "Celebrated-by:" => "remove",<br>
> +);<br>
> +</blockquote><div dir="auto"><br></div><div dir="auto">How did create this list? I thought we looked at 30 cases...</div><div dir="auto"><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
>  our @typeListMisordered = (<br>
>       qr{char\s+(?:un)?signed},<br>
>       qr{int\s+(?:(?:un)?signed\s+)?short\s},<br>
> @@ -2773,8 +2794,28 @@ sub process {<br>
>                       my $ucfirst_sign_off = ucfirst(lc($sign_off));<br>
>  <br>
>                       if ($sign_off !~ /$signature_tags/) {<br>
> -                             WARN("BAD_SIGN_OFF",<br>
> -                                  "Non-standard signature: $sign_off\n" . $herecurr);<br>
> +                             my $suggested_signature = "";<br>
> +                             if (exists($standard_signature_fix{$sign_off})) {<br>
> +                                     $suggested_signature = $standard_signature_fix{$sign_off};<br>
> +                             }<br>
> +                             if ($suggested_signature eq "") {<br>
> +                                     WARN("BAD_SIGN_OFF",<br>
> +                                          "Non-standard signature: $sign_off\n" . $herecurr);<br>
> +                             }<br>
> +                             elsif ($suggested_signature eq "remove") {<br>
> +                                     if (WARN("BAD_SIGN_OFF",<br>
> +                                             "Non-standard signature: $sign_off. Please consider removing this signature tag.\n" . $herecurr) &&<br>
> +                                     $fix) {<br>
> +                                             fix_delete_line($fixlinenr, $rawline);<br>
> +                                     }<br>
> +                             }<br>
> +                             else {<br>
> +                                     if (WARN("BAD_SIGN_OFF",<br>
> +                                             "Non-standard signature: $sign_off. Please use '$suggested_signature' instead.\n" . $herecurr) &&<br>
> +                                     $fix) {<br>
> +                                             $fixed[$fixlinenr] =~ s/$sign_off/$suggested_signature/;<br>
> +                                     }<br>
> +                             }<br>
>                       }<br>
>                       if (defined $space_before && $space_before ne "") {<br>
>                               if (WARN("BAD_SIGN_OFF",<br>
> <br>
<br>
Initial tests performed on patches found this fix to be working as<br>
expected.<br>
<br>
Thanks<br>
Aditya<br>
</blockquote></div></div>