[linux-pm] Re: wakeup code translated to .c

Rafael J. Wysocki rjw at sisk.pl
Sun Feb 3 15:59:38 PST 2008


On Monday, 4 of February 2008, Pavel Machek wrote:
> Hi!
> 
> > BTW, I don't like the way in which the 'struct wakeup_header' fields are
> > reproduced in rm/wakeup.S very much, because it makes the code fragile.
> > It might be better to define the offsets in asm-offsets*.c and refer to them
> > relative to wakeup_header (if possible).
> 
> If you can do that.. yes, that would be nice. I triple-checked it, but
> indeed is fragile.

Do you want me to remove the unused fields from 'struct wakeup_header' too?

Rafael


More information about the linux-pm mailing list