<div dir="ltr">Understood. I will review it and send it back :)<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Sep 26, 2013 at 8:46 AM, Behan Webster <span dir="ltr"><<a href="mailto:behanw@converseincode.com" target="_blank">behanw@converseincode.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 09/26/13 07:34, Tinti wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
Can I merge this patch? I do it quite often to do my tests and I think it might be useful for some one.<br>
<br>
</blockquote></div>
Patches direct in email, not as attachments please. It makes patch review 10x faster, and means people can comment directly on your code. git-send-email is the best tool for the job.<br>
<br>
However, having said that, I see what you're trying to do.<br>
<br>
- I'm not happy with the name of "export". Maybe change it to "export-build-parameters"? It's long, but that's what tab completion is for. ;)<br>
- You don't need to do the seperate patch step, the configure will make sure the kernel is patched.<br>
- You should be doing a "cd ${KERNEL_BUILD}" and "cd ${KERNELGCC_BUILD}" in order to not break things for people using the tmpfs-build system (which builds the kernel out-of-tree on a tmpfs in order to speed compiles, and not wear out SSD drives).<br>
- It also might be worth adding the ARCH and CROSS_COMPILE directives to the kernel make command line. We do it as an env variable in the LLVMLinux build system for convenience. But when you do it at the command line its better form to do it as a part of the make command (makes those settings explicit). Or at least that's my opinion. :)<span class="HOEnZb"><font color="#888888"><br>
<br>
Behan<br>
<br>
-- <br>
Behan Webster<br>
<a href="mailto:behanw@converseincode.com" target="_blank">behanw@converseincode.com</a><br>
<br>
______________________________<u></u>_________________<br>
LLVMLinux mailing list<br>
<a href="mailto:LLVMLinux@lists.linuxfoundation.org" target="_blank">LLVMLinux@lists.<u></u>linuxfoundation.org</a><br>
<a href="https://lists.linuxfoundation.org/mailman/listinfo/llvmlinux" target="_blank">https://lists.linuxfoundation.<u></u>org/mailman/listinfo/llvmlinux</a><br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br><div dir="ltr">Simplicity is the ultimate sophistication<br></div>
</div>