<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Looks safe enough to push to llvmlinux git repo.<div class=""><br class=""></div><div class="">The arm ASM would have to be tested more thoroughly before being upstreaming to mainline.<br class=""><div class=""><br class=""></div><div class="">Behan</div><div class=""><br class=""><div class="">
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; " class=""><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; " class=""><div class="">--</div><div class="">Behan Webster</div><div class=""><a href="mailto:behanw@converseincode.com" class="">behanw@converseincode.com</a></div></div></div><br class="Apple-interchange-newline">
</div>
<br class=""><div><blockquote type="cite" class=""><div class="">On May 31, 2016, at 9:17 AM, Daniel Sanders <<a href="mailto:daniel.sanders@imgtec.com" class="">daniel.sanders@imgtec.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">lib-mpi-extern-inline.patch seems to be upstream.<br class="">lib-mpi-remove-unused.patch: Upstream added 'static' to each one.<br class="">lib-mpi.patch: Upstream added early clobber<br class=""><br class="">Signed-off-by: Daniel Sanders <<a href="mailto:daniel.sanders@imgtec.com" class="">daniel.sanders@imgtec.com</a>><br class="">---<br class="">The updates are fairly minor but there's some ARM-specific inline assembly<br class="">amongst them. Could someone who knows ARM take a look before I push them?<br class=""><br class=""> arch/all/patches/lib-mpi-extern-inline.patch | 34 ----------------------------<br class=""> arch/all/patches/lib-mpi-remove-unused.patch | 21 ++++++++---------<br class=""> arch/all/patches/lib-mpi.patch | 25 ++++++++------------<br class=""> arch/all/patches/series | 1 -<br class=""> 4 files changed, 19 insertions(+), 62 deletions(-)<br class=""> delete mode 100644 arch/all/patches/lib-mpi-extern-inline.patch<br class=""><br class="">diff --git a/arch/all/patches/lib-mpi-extern-inline.patch b/arch/all/patches/lib-mpi-extern-inline.patch<br class="">deleted file mode 100644<br class="">index 9d4c343..0000000<br class="">--- a/arch/all/patches/lib-mpi-extern-inline.patch<br class="">+++ /dev/null<br class="">@@ -1,34 +0,0 @@<br class="">-From bb362cf302b0e953290646ce83e19585536e0d9d Mon Sep 17 00:00:00 2001<br class="">-From: Behan Webster <<a href="mailto:behanw@converseincode.com" class="">behanw@converseincode.com</a>><br class="">-Date: Mon, 27 Oct 2014 11:40:50 -0700<br class="">-Subject: [PATCH] mpi, LLVMLinux: Remove use of extern inline from lib/mpi<br class="">-<br class="">-With compilers which follow the C99 standard (like modern versions of gcc and<br class="">-clang), "extern inline" does the opposite thing from older versions of gcc<br class="">-(emits code for an externally linkable version of the inline function).<br class="">-<br class="">-"static inline" does the intended behavior in all cases instead.<br class="">-<br class="">-Signed-off-by: Behan Webster <<a href="mailto:behanw@converseincode.com" class="">behanw@converseincode.com</a>><br class="">-Suggested-by: Arnd Bergmann <<a href="mailto:arnd@arndb.de" class="">arnd@arndb.de</a>><br class="">-Cc: Arnd Bergmann <<a href="mailto:arnd@arndb.de" class="">arnd@arndb.de</a>><br class="">----<br class="">- lib/mpi/mpi-inline.h | 2 +-<br class="">- 1 file changed, 1 insertion(+), 1 deletion(-)<br class="">-<br class="">-diff --git a/lib/mpi/mpi-inline.h b/lib/mpi/mpi-inline.h<br class="">-index e2b3985..c245ea3 100644<br class="">---- a/lib/mpi/mpi-inline.h<br class="">-+++ b/lib/mpi/mpi-inline.h<br class="">-@@ -30,7 +30,7 @@<br class="">- #define G10_MPI_INLINE_H<br class="">- <br class="">- #ifndef G10_MPI_INLINE_DECL<br class="">--#define G10_MPI_INLINE_DECL extern inline<br class="">-+#define G10_MPI_INLINE_DECL static inline<br class="">- #endif<br class="">- <br class="">- G10_MPI_INLINE_DECL mpi_limb_t<br class="">--- <br class="">-1.9.1<br class="">-<br class="">diff --git a/arch/all/patches/lib-mpi-remove-unused.patch b/arch/all/patches/lib-mpi-remove-unused.patch<br class="">index 95ded19..76fc5fa 100644<br class="">--- a/arch/all/patches/lib-mpi-remove-unused.patch<br class="">+++ b/arch/all/patches/lib-mpi-remove-unused.patch<br class="">@@ -8,35 +8,32 @@ FIXME<br class=""> Signed-off-by: Behan Webster <<a href="mailto:behanw@converseincode.com" class="">behanw@converseincode.com</a>><br class=""> Suggested-by: Arnd Bergmann <<a href="mailto:arnd@arndb.de" class="">arnd@arndb.de</a>><br class=""> Cc: Arnd Bergmann <<a href="mailto:arnd@arndb.de" class="">arnd@arndb.de</a>><br class="">+[Refreshed following upstream addition of 'static']<br class="">+Signed-off-by: Daniel Sanders <<a href="mailto:daniel.sanders@imgtec.com" class="">daniel.sanders@imgtec.com</a>><br class=""> ---<br class=""> lib/mpi/mpi-internal.h | 8 --------<br class=""> 1 file changed, 8 deletions(-)<br class=""><br class="">-diff --git a/lib/mpi/mpi-internal.h b/lib/mpi/mpi-internal.h<br class="">-index b5e538d..7208b39 100644<br class="">---- a/lib/mpi/mpi-internal.h<br class="">-+++ b/lib/mpi/mpi-internal.h<br class="">-@@ -168,20 +168,12 @@ void mpi_rshift_limbs(MPI a, unsigned int count);<br class="">+--- linux.orig/lib/mpi/mpi-internal.h<br class="">++++ linux/lib/mpi/mpi-internal.h<br class="">+@@ -168,20 +168,12 @@<br class=""> int mpi_lshift_limbs(MPI a, unsigned int count);<br class=""><br class=""> /*-- mpihelp-add.c --*/<br class="">--mpi_limb_t mpihelp_add_1(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr,<br class="">+-static inline mpi_limb_t mpihelp_add_1(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr,<br class=""> -<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span> mpi_size_t s1_size, mpi_limb_t s2_limb);<br class=""> mpi_limb_t mpihelp_add_n(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr,<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span> mpi_ptr_t s2_ptr, mpi_size_t size);<br class="">--mpi_limb_t mpihelp_add(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr, mpi_size_t s1_size,<br class="">+-static inline mpi_limb_t mpihelp_add(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr, mpi_size_t s1_size,<br class=""> -<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span> mpi_ptr_t s2_ptr, mpi_size_t s2_size);<br class=""><br class=""> /*-- mpihelp-sub.c --*/<br class="">--mpi_limb_t mpihelp_sub_1(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr,<br class="">+-static inline mpi_limb_t mpihelp_sub_1(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr,<br class=""> -<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span> mpi_size_t s1_size, mpi_limb_t s2_limb);<br class=""> mpi_limb_t mpihelp_sub_n(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr,<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span> mpi_ptr_t s2_ptr, mpi_size_t size);<br class="">--mpi_limb_t mpihelp_sub(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr, mpi_size_t s1_size,<br class="">+-static inline mpi_limb_t mpihelp_sub(mpi_ptr_t res_ptr, mpi_ptr_t s1_ptr, mpi_size_t s1_size,<br class=""> -<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span> mpi_ptr_t s2_ptr, mpi_size_t s2_size);<br class=""><br class=""> /*-- mpihelp-cmp.c --*/<br class=""> int mpihelp_cmp(mpi_ptr_t op1_ptr, mpi_ptr_t op2_ptr, mpi_size_t size);<br class="">--- <br class="">-1.9.1<br class="">-<br class="">diff --git a/arch/all/patches/lib-mpi.patch b/arch/all/patches/lib-mpi.patch<br class="">index d749331..de3c4b1 100644<br class="">--- a/arch/all/patches/lib-mpi.patch<br class="">+++ b/arch/all/patches/lib-mpi.patch<br class="">@@ -12,15 +12,15 @@ Signed-off-by: Behan Webster <<a href="mailto:behanw@converseincode.com" class="">behanw@converseincode.com</a>><br class=""> Not-signed-off-by: Mark Charlebois <<a href="mailto:charlebm@gmail.com" class="">charlebm@gmail.com</a>><br class=""> Suggested-by: Arnd Bergmann <<a href="mailto:arnd@arndb.de" class="">arnd@arndb.de</a>><br class=""> Cc: Arnd Bergmann <<a href="mailto:arnd@arndb.de" class="">arnd@arndb.de</a>><br class="">+[Refreshed following upstream addition of early-clobber]<br class="">+Signed-off-by: Daniel Sanders <<a href="mailto:daniel.sanders@imgtec.com" class="">daniel.sanders@imgtec.com</a>><br class=""> ---<br class=""> lib/mpi/Makefile | 2 ++<br class=""> lib/mpi/longlong.h | 9 +++------<br class=""> 2 files changed, 5 insertions(+), 6 deletions(-)<br class=""><br class="">-diff --git a/lib/mpi/Makefile b/lib/mpi/Makefile<br class="">-index 019a68c..d5553f6 100644<br class="">---- a/lib/mpi/Makefile<br class="">-+++ b/lib/mpi/Makefile<br class="">+--- linux.orig/lib/mpi/Makefile<br class="">++++ linux/lib/mpi/Makefile<br class=""> @@ -4,6 +4,8 @@<br class=""><br class=""> obj-$(CONFIG_MPILIB) = mpi.o<br class="">@@ -30,11 +30,9 @@ index 019a68c..d5553f6 100644<br class=""> mpi-y = \<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span>generic_mpih-lshift.o<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>\<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span>generic_mpih-mul1.o<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>\<br class="">-diff --git a/lib/mpi/longlong.h b/lib/mpi/longlong.h<br class="">-index aac5114..76fc0da 100644<br class="">---- a/lib/mpi/longlong.h<br class="">-+++ b/lib/mpi/longlong.h<br class="">-@@ -193,8 +193,7 @@ extern UDItype __udiv_qrnnd(UDItype *, UDItype, UDItype, UDItype);<br class="">+--- linux.orig/lib/mpi/longlong.h<br class="">++++ linux/lib/mpi/longlong.h<br class="">+@@ -193,8 +193,7 @@<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>"rI" ((USItype)(bl)))<br class=""> #if defined __ARM_ARCH_2__ || defined __ARM_ARCH_3__<br class=""> #define umul_ppmm(xh, xl, a, b) \<br class="">@@ -44,19 +42,16 @@ index aac5114..76fc0da 100644<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>"mov<span class="Apple-tab-span" style="white-space:pre"> </span>%|r2, %3, lsr #16<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>@ BBBB\n" \<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>"bic<span class="Apple-tab-span" style="white-space:pre"> </span>%|r1, %2, %|r0, lsl #16<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>@ aaaa\n" \<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>"bic<span class="Apple-tab-span" style="white-space:pre"> </span>%0, %3, %|r2, lsl #16<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>@ bbbb\n" \<br class="">-@@ -213,10 +212,8 @@ extern UDItype __udiv_qrnnd(UDItype *, UDItype, UDItype, UDItype);<br class="">+@@ -213,10 +212,8 @@<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span>: "r0", "r1", "r2")<br class=""> #else<br class=""> #define umul_ppmm(xh, xl, a, b) \<br class=""> -<span class="Apple-tab-span" style="white-space:pre"> </span>__asm__ ("%@ Inlined umul_ppmm\n" \<br class=""> -<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>"umull %r1, %r0, %r2, %r3" \<br class=""> -<span class="Apple-tab-span" style="white-space:pre"> </span>: "=&r" ((USItype)(xh)), \<br class="">--<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>"=r" ((USItype)(xl)) \<br class="">+-<span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>"=&r" ((USItype)(xl)) \<br class=""> +<span class="Apple-tab-span" style="white-space:pre"> </span>__asm__ ("umull %1, %0, %2, %3" \<br class="">-+<span class="Apple-tab-span" style="white-space:pre"> </span>: "=&r" ((xh)), "=r" ((xl)) \<br class="">++<span class="Apple-tab-span" style="white-space:pre"> </span>: "=&r" ((xh)), "=&r" ((xl)) \<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span>: "r" ((USItype)(a)), \<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>"r" ((USItype)(b)) \<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span>: "r0", "r1")<br class="">--- <br class="">-1.9.1<br class="">-<br class="">diff --git a/arch/all/patches/series b/arch/all/patches/series<br class="">index 0db8ba4..4eeae7e 100644<br class="">--- a/arch/all/patches/series<br class="">+++ b/arch/all/patches/series<br class="">@@ -8,7 +8,6 @@ kbuild-asm-defines.patch<br class=""> kbuild-cc-option.patch<br class=""> #ethernet-emulex.patch<br class=""> lib-mpi.patch<br class="">-lib-mpi-extern-inline.patch<br class=""> lib-mpi-not-clang.patch<br class=""> lib-mpi-remove-unused.patch<br class=""> nested-function-md_bcache_sysfs.patch<br class="">-- <br class="">2.1.4<br class=""><br class="">_______________________________________________<br class="">LLVMLinux mailing list<br class=""><a href="mailto:LLVMLinux@lists.linuxfoundation.org" class="">LLVMLinux@lists.linuxfoundation.org</a><br class="">https://lists.linuxfoundation.org/mailman/listinfo/llvmlinux<br class=""></div></div></blockquote></div><br class=""></div></div></body></html>