[Fwd: Re: [Openais] Logging patch.]

Steven Dake sdake at mvista.com
Thu Oct 28 14:48:48 PDT 2004


On Thu, 2004-10-28 at 12:19, Daniel Stodden wrote:
> sorry again :P 
> 
> ______________________________________________________________________
> From: Daniel Stodden <stodden at cs.tum.edu>
> To: scd at broked.org
> Subject: Re: [Openais] Logging patch.
> Date: Thu, 28 Oct 2004 21:18:32 +0200
> 
> On Thu, 2004-10-28 at 10:28 -0700, Steven Dake wrote:
> > Daniel
> > 
> > Separate functions for each log level seem like a good idea to me.  I'm
> > not sure how the stack is different for the changes you have made (was
> > it va_start/va_end that was causing the problem?), but the changes look
> > fine to me.
> 
> i suppose. i must admit i didn't find that problem and i didn't feel
> like i had the time to single step through the assembler.
> 
> > Could you fix a few things though?
> > 
> > 1. ais_error should be ais_log_error.  Same for the other functions.
> > 
> 
> 
> > 2. There must be a ais_log_security and ais_log_debug.
> 
> _debug should have already been there. the rest can be added easily.
> 
> > 3. LOG_SERVICE should remain undefined and should cause a compile error
> > if it is undefined.  This happens now automatically but it could be
> > cleaner with something like this in the print.h header file:
> > #ifndef LOG_SERVICE
> > #error "you must define LOG_SERVICE in any source file that includes
> > print.h"
> > #endif
> 
> good, i prefer that. changed my mind because i wanted to keep it
> backwards-compatible for now, and evt.c was missing the define yet
> (still may miss it).
> 
> > 4. I do not like the compatibility functions.  Either we use one set of
> > functions or the other.  Hence, all the users should be changed to use
> > the new log functions.  Also the compatibility stuff should be removed.
> 
> i didn't suggest to them. just wanted to send something which compiles
> to get input whether it's okay to proceed in that direction.
> 
> 

Daniel
Cool then I think we are in good shape with this approach.  Could you
make a full patch of all the changes needed without the compat?  Also
you will have to make some kind of change to gmi_log_printf_init() and
gmi.c to get rid of the compatability functions.

Regards
-steve

> regards,
> daniel
> 
> ______________________________________________________________________
> _______________________________________________
> Openais mailing list
> Openais at lists.osdl.org
> http://lists.osdl.org/mailman/listinfo/openais




More information about the Openais mailing list