[Openais] (no subject)
Mark Haverkamp
markh at osdl.org
Mon Jul 25 10:21:16 PDT 2005
On Thu, 2005-07-21 at 19:48 +0530, Trivikram wrote:
> Hi Steve,
>
>
>
> In Publish API we are trying to allocate memory for req (in line
> 1820 lib/evt.c), before checking memory is allocated or not we are
> using req
>
> I think it is better to check before using it.
>
Good idea. I missed that.
>
>
> In subscribe library handler we are checking subscriber is
> already present or not after calling evtfilt_to_aisfilt (in line 2343
> exec/evt.c)
>
> I think it is better call evtfilt_to_aisfilt after checking (get the
> channel instance and find the subscriber then call
> evtfilt_to_aisfilt).
>
>
Sounds OK to me.
>
I'll fix these and check them in.
Mark.
--
Mark Haverkamp <markh at osdl.org>
More information about the Openais
mailing list