[Openais] [PATCH] Use objdb

Patrick Caulfield pcaulfie at redhat.com
Mon Apr 10 07:17:05 PDT 2006


Hans Feldt wrote:
> Patrick Caulfield wrote:
>> Hans Feldt wrote:
>>
>>> A couple of things:
>>>
>>> 1. The default user/group config is not working. A line with:
>>>
>>>    objdb->object_find_reset (OBJECT_PARENT_HANDLE);
>>>
>>> before the aisexec section fixes the problem.
>>>
>>> 2. BUILD_DYNAMIC=0 does not work. amfconfig.c missing in build.
>>
>>
>> Good catch, I've fixed those two now. (patch attached).
> 
> OK.
> 
>>> 4. I think the location of openais.conf should be configurable at the
>>> aisexec command line and not at compile time. Of course defaults to
>>> /etc/ais.
> 
> In order to specify location of openais.conf on the command line, the
> interface to aisparser.c needs a change. Is it OK to change the
> config_readconfig prototype in config.h? I need a "char *config_file*
> there.

Hmm, the problem there is that the config interface is supposed to be generic,
so that a file name would be meaningless to some configurators.

> BTW, are there plans on fixing the search for .lcrso file in current
> directory? 'make install' does not copy these files. Wouldn't it be
> better to specify services to be loaded in the config file and let
> dlopen() find the library acc. to its built in rules?
> 
> Regards,
> Hans
> 


-- 

patrick



More information about the Openais mailing list