[Openais] totempg reentrancy

[Muni Bajpai]

Steve,

Sorry was already gone by the time you had sent the 1st message.

My take on this not being viewable in CKPT is the fulfillment of the
condition that messages are being queued for mcast faster than they are
being delivered and I don't believe that has happened. Nonetheless as
you stated later we should think about totempg and multithreading

So I have nothing to add to this.

Muni

-----Original Message-----
From: openais-bounces at lists.osdl.org
[mailto:openais-bounces at lists.osdl.org] On Behalf Of Steven Dake
Sent: Friday, January 20, 2006 4:21 PM
To: openais at lists.osdl.org
Subject: [Openais] totempg reentrancy


I found during debugging AMF some strange behavior in the totempg layer.
I tracked it down to the fact that totempg_mcast (or msg_mcast) is not
reentrant, meaning it is not possible to call a mcast from a message
handler that was delivered a message.

This happens within the AMF quite often, and may also happen within the
CKPT and EVT resynchronization.  Muni do you know for sure it happens in
ckpt resync?

I think this is something we will have to fix before we finally release
0.70.1.

I have attached a patch which fixes the problem for trunk.  Could we get
some review then I'll work up something for picacho?

I have thought through this patch and it appears to solve multiple
levels of reentrancy as well, but I could use more eyes and brains to
think about the problem.

Thanks
-steve