[Openais] gold plating version 2 - with marks changes

[Steven Dake]

ok I've applied this to the gold plating patch

On Wed, 2006-01-25 at 07:22 -0800, Mark Haverkamp wrote:
> On Tue, 2006-01-24 at 17:56 -0700, Steven Dake wrote:
> > Folks,
> > Here is the gold plating patch that applies to the latest trunk.  I'm
> > going to merge this in the next few days so we can work on the rest of
> > the abstractions for dynamic service handlers.
> > 
> > Mark with this patch I get a compile warning:
> > 
> > cc -O3 -Wall -DBUILD_DYNAMIC=1 -fPIC -c -o evt.o evt.c
> > evt.c: In function `evt_chan_open_finish':
> > evt.c:3328: warning: `timer_del_status' might be used uninitialized in
> > this function
> > 
> > I'm not sure if we s hould set timer_del_status to 0 or 1 to start.
> 
> This should fix the warnings.
> 
> Index: exec/evt.c
> ===================================================================
> --- exec/evt.c  (revision 905)
> +++ exec/evt.c  (working copy)
> @@ -3320,13 +3320,13 @@
>  static void evt_chan_open_finish(struct open_chan_pending *ocp,
>                 struct event_svr_channel_instance *eci)
>  {
> -       uint32_t handle;
>         struct event_svr_channel_open *eco;
>         SaAisErrorT error = SA_AIS_OK;
>         struct libevt_ci *esip = &ocp->ocp_conn_info->ais_ci.u.libevt_ci;
>         unsigned int ret = 0;
> -       unsigned int timer_del_status;
> -       void *ptr;
> +       unsigned int timer_del_status = 0;
> +       void *ptr = 0;
> +       uint32_t handle = 0;
> 
>         log_printf(CHAN_OPEN_DEBUG, "Open channel finish %s\n",
>                                                                                getSaNameT(&ocp->ocp_chan_name));
> 
> _______________________________________________
> Openais mailing list
> Openais at lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/openais