[Openais] CKPT: bug, checkpoints without sections not synchronized

Steven Dake sdake at redhat.com
Wed Sep 6 15:20:40 PDT 2006


On Wed, 2006-09-06 at 09:38 -0500, Muni Bajpai wrote:
> Actually there has to be a default section in all checkpoints. So no there 
> shouldnt be any sections without checkpoints.
> 
> Also the test case definitely works in picacho and hence has been introduced 
> with the ckpt_id.

According to specifications a default section is only created when
MaxSections = 1 in the creation attributes.  Otherwise, there should not
be a default section.

You wouldn't think this would make a big deal, but it breaks things for
user applications like iteration, which might inadvertantly iterate a
default section.

Regards
-steve

> ----- Original Message ----- 
> From: "Hans Feldt" <Hans.Feldt at ericsson.com>
> To: <openais at lists.osdl.org>
> Sent: Wednesday, September 06, 2006 6:27 AM
> Subject: [Openais] CKPT: bug, checkpoints without sections not synchronized
> 
> 
> >From ckpt.c:
> 
> > /*
> > * ALGORITHM :
> > * 1.) extract the checkpoint if there.
> > * 2.) If there is a checkpoint then there has to be a section
> > * 3.) If the recovery_section_send_flag was not set in the previous
> > * invocation that means we have to send out a sync_msg before
> > * we send out the sections
> > * 4.) Set the recovery_section_send_flag and send the sections.
> > */
> 
> Number 2 is wrong. There can be checkpoints without sections and they
> should be synced.
> 
> I did not want to create a patch for this problem since it can be solved
> in different ways and the problem is more complicated than previous ckpt
> patches.
> 
> Regards,
> Hans
> 
> _______________________________________________
> Openais mailing list
> Openais at lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/openais 
> 
> _______________________________________________
> Openais mailing list
> Openais at lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/openais




More information about the Openais mailing list