[Openais] Patch for more graceful error handling w/ AMF
Steven Dake
sdake at redhat.com
Thu Sep 27 02:25:38 PDT 2007
Drew,
Thanks I'll take a look at fixing this problem
Regards
-steve
On Mon, 2007-09-24 at 16:30 -0700, Drew Moseley wrote:
> Steven Dake wrote:
> >> Index: exec/amfcomp.c
> >> ===================================================================
> >> --- exec/amfcomp.c (revision 1452)
> >> +++ exec/amfcomp.c (working copy)
> >> @@ -694,6 +694,9 @@
> >> char *ptrptr;
> >> char *buf;
> >>
> >> + if (cluster == NULL || name == NULL)
> >> + return NULL;
> >> +
> >>
> > same comment above about assertions here ^^
> >
>
> This occurs when amf is explicitly disabled in openais.conf. If you
> then run,
>
> ../test/clc_cli_script instantiate ../test/testamf1
>
> aisexec will crash by dereferencing amf_cluster is NULL. Is there a
> better way
> to ensure a graceful exit in this case?
>
> Drew
More information about the Openais
mailing list