[Openais] message service: was Re: [PATCH] Synchronization for Message Service

Steven Dake sdake at redhat.com
Sat Aug 23 20:08:36 PDT 2008


There is an API for reporting out of memory errors.  Look in coroapi
(api->error_memory_report i think:)

Other then that, you should be proud of having written the most
difficult and complex part of any service engine and doing a great job
on wrapping up the message service overall.  There may be a few bugs
around conformance issues, but overall things look very clean and well
done.  Again, great job!

Please commit the patch when ready (with the proper error report api
used.)

Regards
-steve 

On Fri, 2008-08-22 at 17:54 -0500, Ryan O'Hara wrote:
> Attached is a patch to add synchronization capabilities to the message
> service. This code should sync queue groups, message queues, and
> messages.
> 
> A brief word about how it is designed: The first pass of the
> synchronization code will iterate over the queue_list_head,
> synchronizing all message queues and messages within those queues. In
> the second pass, the code will handle queue groups. The queues that
> exist within those groups should have already been sync'd, so we
> simply have to add the group and add the correct queues to the group.
> 
> Also note that there is an important fix included in this patch. There
> was a problem with saMsgQueueGroupInsert where is would incorrectly
> add the queue to be inserted into the queue_list_head.
> 
> Ryan
> 
> _______________________________________________
> Openais mailing list
> Openais at lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/openais



More information about the Openais mailing list