[Openais] [corosync] [RFE] - Support for -v (version) option

Jan Friesse jfriesse at redhat.com
Thu Jul 30 07:34:47 PDT 2009


Patch version 3. Uses approach of
- delete exec/version.h from svn control
- generate it from configure.ac AND svnversion in autogen.sh

Regards,
  Honza

Jan Friesse wrote:
> Steve,
> I'm looking on tagging script (I hope it's Makefile in root).
> 
> First thing:
> - Do we really need patch to show revision? Becase line 101 (and 40 for
> flatron):
> 
>         # set version
>         echo "#define RELEASE_RELVERSION \"subrev $(REV) corosync
> version $(RELVERSION)\"" \
>                 > tags/corosync-$(RELVERSION)/version.h
> 
> should generate correct informations to version.h file. But this
> version.h is never published to SVN so we can't use it.
> 
> What this file is good for?
> 
> I really don't understand, what tag version you want to set. RELVERSION?
> In this case, can? we:
> - change line 102-103 (41-42) to generate exec/version.h
> - use RELVERSION in all VERSION outputs
> 
> or
> 
> - remove line 101-103 (40-43) from tagging script
> - remove exec/version.h from svn (I totally agree with Fabio, that
> rewriting something what is in version system control is ugly)
> - use only autogen.sh to generate exec/version.h
> 
> Regards,
>   Honza
> 
> Steven Dake napsal(a):
>> autogen.sh should detect the tag version or honor that which is done in
>> the tagging script.  Have you looked at how the tagging script sets the
>> version variable?
>>
>> Regards
>> -steve
>> On Tue, 2009-07-28 at 12:17 +0200, Jan Friesse wrote:
>>> See SUBJ and Patch.
>>>
>>> Regards,
>>>   Honza
>>> _______________________________________________
>>> Openais mailing list
>>> Openais at lists.linux-foundation.org
>>> https://lists.linux-foundation.org/mailman/listinfo/openais
>>
> 
> 

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: corosync-version-take3.patch
Url: http://lists.linux-foundation.org/pipermail/openais/attachments/20090730/3d34651e/attachment.txt 


More information about the Openais mailing list