[Openais] [lck 2/7] Sizeof should be structure and not pointer

Jan Friesse jfriesse at redhat.com
Tue Jun 2 08:55:43 PDT 2009


Of course we can.

Ryan O'Hara wrote:
> This patch is correct, but what I intended was to use sizeof (struct
> resource_instance). Can we do that instead?
> 
> 
> 
> On Tue, Jun 02, 2009 at 05:34:04PM +0200, Jan Friesse wrote:
>> ---
>>  trunk/services/lck.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/trunk/services/lck.c b/trunk/services/lck.c
>> index 099835c..383e862 100644
>> --- a/trunk/services/lck.c
>> +++ b/trunk/services/lck.c
>> @@ -2042,7 +2042,7 @@ error_exit:
>>  			 * Create resource instance.
>>  			 */
>>  			hdb_handle_create (&resource_hdb,
>> -				sizeof (resource_instance), &resource_id);
>> +				sizeof (*resource_instance), &resource_id);
>>  			hdb_handle_get (&resource_hdb,
>>  				resource_id, (void *)&resource_instance);
>>  			memcpy (&resource_instance->source,
>> @@ -2150,7 +2150,7 @@ error_exit:
>>  			 * Create resource instance.
>>  			 */
>>  			hdb_handle_create (&resource_hdb,
>> -				sizeof (resource_instance), &resource_id);
>> +				sizeof (*resource_instance), &resource_id);
>>  			hdb_handle_get (&resource_hdb,
>>  				resource_id, (void *)&resource_instance);
>>  			memcpy (&resource_instance->source,
>> -- 
>> 1.5.5.6
>>
>> _______________________________________________
>> Openais mailing list
>> Openais at lists.linux-foundation.org
>> https://lists.linux-foundation.org/mailman/listinfo/openais



More information about the Openais mailing list