[Openais] [lck 6/7] Remove some compiler warnings.

Ryan O'Hara rohara at redhat.com
Tue Jun 2 08:58:13 PDT 2009


Actually, can we just #ifdef out the print routines? They are useful
for debugging while we work out the bugs. Just easier to remove ifdef
here and there.


On Tue, Jun 02, 2009 at 05:34:08PM +0200, Jan Friesse wrote:
> It looks like really useful warning is only in header file,
> because there were one ";" character more, then should be.
> ---
>  trunk/include/ipc_lck.h |    2 +-
>  trunk/services/lck.c    |    9 +++++----
>  2 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/trunk/include/ipc_lck.h b/trunk/include/ipc_lck.h
> index cb1bd2a..a1e42c1 100644
> --- a/trunk/include/ipc_lck.h
> +++ b/trunk/include/ipc_lck.h
> @@ -157,7 +157,7 @@ struct req_lib_lck_resourceunlockasync {
>  } __attribute__((aligned(8)));
>  
>  struct res_lib_lck_resourceunlockasync {
> -	coroipc_response_header_t header; __attribute__((aligned(8)));
> +	coroipc_response_header_t header __attribute__((aligned(8)));
>  } __attribute__((aligned(8)));
>  
>  struct req_lib_lck_lockpurge {
> diff --git a/trunk/services/lck.c b/trunk/services/lck.c
> index 055c8ad..2872a47 100644
> --- a/trunk/services/lck.c
> +++ b/trunk/services/lck.c
> @@ -851,6 +851,7 @@ static void lck_confchg_fn (
>  	return;
>  }
>  
> +/***** REMOVE ****
>  static void lck_print_pr_pending_list (
>  	struct resource *resource)
>  {
> @@ -909,7 +910,7 @@ static void lck_print_ex_pending_list (
>  		log_printf (LOGSYS_LEVEL_DEBUG, "[DEBUG]:\t lock_id=%u (status=%d)\n",
>  			    (unsigned int)(lock->lock_id), lock->lock_status);
>  	}
> -}
> +}*/
>  
>  static void lck_print_resource_lock_list (
>  	struct resource *resource)
> @@ -2630,7 +2631,7 @@ static void message_handler_req_exec_lck_limitget (
>  	/* DEBUG */
>  	log_printf (LOGSYS_LEVEL_DEBUG, "EXEC request: saLckResourceLimitGet\n");
>  
> -error_exit:
> +/*error_exit:*/
>  	if (api->ipc_source_is_local (&req_exec_lck_limitget->source))
>  	{
>  		res_lib_lck_limitget.header.size =
> @@ -2653,7 +2654,7 @@ static void message_handler_req_exec_lck_resourcelock_timeout (
>  	const struct req_exec_lck_resourcelock_timeout *req_exec_lck_resourcelock_timeout =
>  		message;
>  	struct res_lib_lck_resourcelock res_lib_lck_resourcelock;
> -	SaAisErrorT error = SA_AIS_OK;
> +/*	SaAisErrorT error = SA_AIS_OK;*/
>  
>  	struct resource *resource = NULL;
>  	struct resource_lock *resource_lock = NULL;
> @@ -3211,7 +3212,7 @@ static void message_handler_req_lib_lck_limitget (
>  	void *conn,
>  	const void *msg)
>  {
> -	const struct req_lib_lck_limitget *req_lib_lck_limitget = msg;
> +/*	const struct req_lib_lck_limitget *req_lib_lck_limitget = msg;*/
>  	struct req_exec_lck_limitget req_exec_lck_limitget;
>  	struct iovec iovec;
>  
> -- 
> 1.5.5.6
> 
> _______________________________________________
> Openais mailing list
> Openais at lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/openais


More information about the Openais mailing list