[Openais] [PATCH]: openais/trunk: Check for valid lock_id before invoking saLckLockGrantCallback

Steven Dake sdake at redhat.com
Tue Jun 9 15:40:19 PDT 2009


Patch needs to do a handle put after executing the dispatch routine.

Regards
-steve

On Wed, 2009-06-10 at 11:57 -0500, Ryan O'Hara wrote:
> If we request a lock via saLckLockRequestAsync, which is granted, an
> saLckLockGrantCallback will be generated. The callback request is sent
> to the dispatcher, but it is possible to unlock this lock before the
> callback is invoked. The specification clearly states that this should
> result in saLckLockGrantCallback returning SA_AIS_ERR_NOT_EXIST.
> 
> The best way to handle this is to add a check to saLckDispatch that
> verifies that the lock_id is valid before invoking
> saLckLockGrantCallback. This add this check.
> 
> Thanks again to Honzaf for finding this bug.
> 
> Ryan
> 
> _______________________________________________
> Openais mailing list
> Openais at lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/openais



More information about the Openais mailing list