[Openais] [PATCH openais 2/9] avoid useless if before free

Jim Meyering jim at meyering.net
Sun Jun 21 11:42:52 PDT 2009


From: Jim Meyering <meyering at redhat.com>

* services/msg.c (message_handler_req_exec_msg_queueopen): Remove
unnecessary "if" before free.
(message_handler_req_exec_msg_queueopenasync): Likewise.
(message_handler_req_exec_msg_messageget): Likewise.
---
 services/msg.c |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/services/msg.c b/services/msg.c
index d4f7ec1..c0cf6dd 100644
--- a/services/msg.c
+++ b/services/msg.c
@@ -2629,8 +2629,7 @@ error_exit:
 			list_add_tail (&cleanup->list, &msg_pd->queue_cleanup_list);
 		}
 		else {
-			if (cleanup)
-				free (cleanup);
+			free (cleanup);
 		}

 		api->ipc_response_send (
@@ -2799,8 +2798,7 @@ error_exit:
 			list_add_tail (&cleanup->list, &msg_pd->queue_cleanup_list);
 		}
 		else {
-			if (cleanup)
-				free (cleanup);
+			free (cleanup);
 		}

 		api->ipc_response_send (
@@ -3956,8 +3954,7 @@ error_exit:
 		}
 	}

-	if (msg != NULL)
-	    free (msg);
+	free (msg);
 }

 static void message_handler_req_exec_msg_messagedatafree (
-- 
1.6.3.2.448.g363bdb



More information about the Openais mailing list