[Openais] [PATCH][corosync] Return CS_ERR_INTERRUPT to library users
Steven Dake
sdake at redhat.com
Fri Jun 26 08:08:31 PDT 2009
will do
regards
-steve
On Fri, 2009-06-26 at 13:03 +0100, Chrissie Caulfield wrote:
> Chrissie Caulfield wrote:
> > Steven Dake wrote:
> >> On Thu, 2009-06-25 at 16:25 +0100, Chrissie Caulfield wrote:
> >>> Steven Dake wrote:
> >>>> The change is a good idea, but I'd rather not stick more error code
> >>>> handling requirements on the user. Can't we just use try again instead?
> >>>>
> >>> Hmmm
> >>>
> >>> ERR_INTERRUPT is already a listed return code, and most people doing
> >>> communications are used to trapping something similar I think. Also I
> >>> don't really think that ERR_TRY_AGAIN properly captures what has happened.
> >>>
> >>> But I'm not going to get anal about this. Does anyone else have an opinion?
> >>>
> >> Chrissie,
> >>
> >> This change has profound changes across all the API interfaces. It
> >> would trigger every single API to deliver an ERR_INTERRUPT to the user
> >> in this use case.
> >>
> >> For example, if saCkptSectionCreate was interrupted, it would return
> >> this error code. Unfortunately SA Forum didn't specify ERR_INTERRUPT in
> >> the list of valid return codes there, so we would have to trap in every
> >> library call in openais for this error code and return a sa forum
> >> specified error code (such as try again).
> >>
> >> I'm really concerned this could cause breakage all over cluster 3 and
> >> downstream without proper trapping in the SA Forum services.
> >>
> >> I don't want to introduce such a change so near release that requires
> >> reworking all the library api calls so near release.
> >>
> >> Can we go with TRY_AGAIN for now, and then adjust to ERR_INTERRUPT once
> >> we have a proper openais munging of this error code?
> >>
> >
> > OK, I give in. Here's a changed patch that returns ERR_TRY_AGAIN. The
> > point that daemons can take action when interrupted is the main goal.
> >
> > I also didn't realise that ERR_INTERRUPT was not an SA-FORUM return code.
> >
> > Added to which if this patch doesn't go in today it'll miss all the
> > deadlines and all sorts of people will whinge that daemons are
> > unkillable. They whinge at Fabio mainly but he does pass them down to me
> > fairly often ...
> >
>
> Steven,
>
> I'll be on holiday by the time you read this. If the patch is ACKed can
> you apply it please?
>
> Thanks,
>
>
> Chrissie
More information about the Openais
mailing list