[Openais] [PATCH]: openais/trunk: Retuen SA_AIS_OK when unlocking pending lock request

Ryan O'Hara rohara at redhat.com
Mon Jun 29 14:33:32 PDT 2009


When unlocking a pending lock request, we must send a response to the
library. The error for such an operation should be SA_AIS_OK.

Previously, this operation would return an error of
SA_AIS_ERR_TIMEOUT. This was an arbitrary decision since the spec does
not clearly define what the error should be for such an
operation. However, it seems that saftest expects that the lock
operation should get SA_AIS_OK and the the status must not be
GRANTED. This seems reasonable.

Ryan

-------------- next part --------------
Index: services/lck.c
===================================================================
--- services/lck.c	(revision 2011)
+++ services/lck.c	(working copy)
@@ -1846,7 +1846,7 @@
 		if (resource_lock->lock_status == 0) {
 			if (resource_lock->timer_handle != 0) {
 				api->timer_delete (resource_lock->timer_handle);
-				lck_resourcelock_response_send (resource_lock, SA_AIS_ERR_TIMEOUT);
+				lck_resourcelock_response_send (resource_lock, SA_AIS_OK);
 			}
 		}
 	}


More information about the Openais mailing list