[Openais] [PATCH 1/4] Add value types to objdb keys.

Angus Salkeld angus.salkeld at gmail.com
Fri Oct 9 20:23:53 PDT 2009


Hi

1) changed _ext to _typed
2) fixed some tabbing (hopefully all of it).
3) fixed some warnings.

Committed as 2511.

Regards
Angus Salkeld

On Fri, 9 Oct 2009, Steven Dake wrote:

> patck looks pretty good few comments inline
>
> please fix the tabbing though its painful :)
>
> Regards
> -steve
>
> On Wed, 2009-09-23 at 14:40 +1200, angus salkeld wrote:
>> This allows you to create a key with a know type.
>> And then get the type with the key value.
>>
>> Signed-off-by: Angus Salkeld <angus.salkeld at alliedtelesis.co.nz>
>> ---
>>  exec/apidef.c                     |    3 +
>>  exec/coroparse.c                  |    5 +-
>>  exec/objdb.c                      |  115 ++++++++++++++++++----
>>  exec/service.c                    |   20 ++--
>>  include/corosync/confdb.h         |   37 +++++++
>>  include/corosync/engine/coroapi.h |   36 +++++++
>>  include/corosync/engine/objdb.h   |   35 +++++++
>>  include/corosync/ipc_confdb.h     |   28 +++++-
>>  lib/confdb.c                      |  200 +++++++++++++++++++++++++++++++++++++
>>  lib/sa-confdb.c                   |   60 +++++++++++
>>  lib/sa-confdb.h                   |   16 +++
>>  services/confdb.c                 |  107 ++++++++++++++++++++
>>  tools/corosync-objctl.c           |   65 ++++++++++---
>>  13 files changed, 677 insertions(+), 50 deletions(-)
>>
>> diff --git a/exec/apidef.c b/exec/apidef.c
>> index a8ae751..9916d62 100644
>> --- a/exec/apidef.c
>> +++ b/exec/apidef.c
>> @@ -172,6 +172,9 @@ void apidef_init (struct objdb_iface_ver0 *objdb) {
>>  	apidef_corosync_api_v1.object_reload_config = objdb->object_reload_config;
>>  	apidef_corosync_api_v1.object_key_increment = objdb->object_key_increment;
>>  	apidef_corosync_api_v1.object_key_decrement = objdb->object_key_decrement;
>> +	apidef_corosync_api_v1.object_key_create_ext = objdb->object_key_create_ext;
>> +	apidef_corosync_api_v1.object_key_get_ext = objdb->object_key_get_ext;
>> +	apidef_corosync_api_v1.object_key_iter_ext = objdb->object_key_iter_ext;
>>  }
>>
>
> instead of _ext can we call these _typed?
>


More information about the Openais mailing list