[Openais] [PATCH corosync/trunk] add some missing stats "++"

Steven Dake sdake at redhat.com
Tue Oct 13 09:39:12 PDT 2009


On Tue, 2009-10-13 at 14:39 +0100, Christine Caulfield wrote:
> On 12/10/09 22:57, angus salkeld wrote:
> > On Mon, 2009-10-12 at 14:42 -0700, Steven Dake wrote:
> >> good for merge
> >>
> > Committed as revision 2519.
> >
> > -Angus
> >
> 
> The stats can crash corosync if token_count is zero ... don't laugh I've 
> seen it crash several times with this already. This patch checks that 
> token_count is nozero before using it as a divisor.
> 
> Chrissie

Chrissie

good catch

this brings up an interesting class of bugs (div by zero).  Angus can
you double check those div by zeros don't happen?

Regards
-steve


> _______________________________________________
> Openais mailing list
> Openais at lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/openais



More information about the Openais mailing list