[Openais] [PATCH] Respect user LDFLAGS, don't enforce any additional CFLAGS by default

Fabio M. Di Nitto fdinitto at redhat.com
Wed Aug 25 02:20:57 PDT 2010


On 8/25/2010 11:16 AM, Kacper Kowalik wrote:
> W dniu 25.08.2010 10:37, Fabio M. Di Nitto pisze:
>> On 8/25/2010 10:26 AM, Kacper Kowalik wrote:
>>> Hi,
>>> I would like to ask for inclusion regarding two issues:
>>>  1) respect LDFLAGS env during linking
> 
>> this is good one, did you check if all Makefiles.am do respect LD_FLAGS
>> already? If not, the change should probably be more global.
> 
> Yup, that's all I found. You can verify this by:
>  1. export LDFLAGS=-Wl,--hash-style=gnu
>  2. build
>  3. scanelf -qyRF '%k %p' -k .hash ${BUILDIR} | sed -e "s:\.hash ::"

Ok, I take your word for it :)

> 
>>>  2) don't enforce any optimization/debug flags by default
> 
>> hmm I disagree here.
> 
>> -O3 is necessary to obtain performance out of the sober crypto code. I
>> recall a major impact in performance with anything lower than that.
> Remember that setting no flags is eqv. to -O2, but it doesn't matter here.
> If you have a set of flags that you consider as "best" for your package
> please use them. Make them even default. I only ask for a possibility to
> switch them off, e.g. by --disable-optimization. This way it won't
> change current behaviour of openais at all and will suite my needs.

Yes, I understand the issue, then let´s make your patch "backwards" to
allow --disable-optimizations rather than changing the defaults. I
gather that would work for you and I don´t have a problem with that.

Fabio


More information about the Openais mailing list