[Openais] SNMP for corosync

[Steven Dake]

On Tue, 2010-03-16 at 18:19 +0900, Keisuke MORI wrote:
> Dear Steven,
> 
> Thank you for considering the patch.
> I'm very look forward to the SNMP feature to be merged into the next release.
> It is one of the important feature for us to migrate from Heartbeat to
> Pacemaker+Corosync stack.
> 
> 
> Just for making sure...
> >> OID: 5649112
> >> (OID is draft)
> 
> Sato-san's patch uses a tentative value for the enterprise OID of the trap.
> Will you please obtain the official OID for the use of the Corosync project
> and change the value accordingly when you merge?
> http://pen.iana.org/pen/PenApplication.page
> 
> You may have already noticed but for just in case...
> 
> 

Thank you for your kind response.  I know little about SNMP and have
requested a OID.  We will have an assigned OID in short order.

> Regards,
> 
> Keisuke MORI
> 
> 2010/3/12 Steven Dake <sdake at redhat.com>:
> > Sato-san,
> >
> > Really nice initial work.  I have few comments on the patch which are
> > nitpicky but which once resolved, can be merged.
> >
> > first the high level issues:
> >
> > configure --with-snmp should be --enable-snmp.
> >
> > The configure.ac SUPPORT_SNMP variable should be enable_snmp
> >
> > Running configure --enable-snmp should assume a "yes" value
> >
> > Running configure without --enable-snmp should create a build without
> > snmp support.
> >
> > "Features" should print out "snmp" in the configure output ie:
> >
> >  Features                 = nss snmp
> >
> > The package should error during the configure step if net-snmp-devel
> > package is not installed and snmp is enabled.  Currently it just doesn't
> > build snmp support without giving any warning.  This is likely confusing
> > to users.
> >
> > I get the following after installing when running.
> >
> > Mar 11 14:43:51 corosync [SERV  ] Service engine loaded: corosync
> > profile loading service
> > /usr/libexec/lcrso/service_snmp.lcrso: open
> > failed: /usr/libexec/lcrso/service_snmp.lcrso: undefined symbol:
> > snmp_send
> >
> > I looked over the Makefile and the output looks correct on my f11 system
> > - not sure why its not working.
> >
> > SNMPLIBS is way overloaded.  I manually compiled as follows:
> >
> > gcc `net-snmp-config --libs` -shared -Wl,-soname=service_snmp.lcros
> > snmp.o -o service_snmp.lcrso
> >
> > This gives the dependencies:
> > [root at localhost services]# ldd service_snmp.lcrso
> >        linux-gate.so.1 =>  (0x00ef4000)
> >        libcrypto.so.8 => /usr/lib/libcrypto.so.8 (0x00afc000)
> >        libsensors.so.4 => /usr/lib/libsensors.so.4 (0x00a4e000)
> >        libnetsnmp.so.15 => /usr/lib/libnetsnmp.so.15 (0x007c6000)
> >        libc.so.6 => /lib/libc.so.6 (0x0053b000)
> >        libdl.so.2 => /lib/libdl.so.2 (0x0090a000)
> >        libz.so.1 => /lib/libz.so.1 (0x00297000)
> >        libm.so.6 => /lib/libm.so.6 (0x00110000)
> >        /lib/ld-linux.so.2 (0x003e9000)
> >
> > SNMPLIBS in my makefile on the other hand has many other unneeded
> > dependencies:
> > SNMPLIBS = -lcrypto -lsensors -L/usr/lib -lnetsnmpagent -lnetsnmphelpers
> > -lnetsnmpmibs -lnetsnmp -lz -Wl,-E
> > -Wl,-rpath,/usr/lib/perl5/5.10.0/i386-linux-thread-multi/CORE
> > -L/usr/local/lib -L/usr/lib/perl5/5.10.0/i386-linux-thread-multi/CORE
> > -lperl -lresolv -lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
> >
> > Also -rpath is not allowed in corosync.
> >
> > when running I see:
> > Mar 11 14:57:10 corosync [SNMP  ] ringid:340    nodeid:1        famiry:2
> > ip:192.168.1.105.
> > Log SNMP messages at debug level
> >
> > famiry is a typo - should be family
> >
> > additional comments inline in the patch.
> >
> > make distcheck fails.  That must work to be able to merge the patch,
> > since that is part of our release process.  There are two ways to solve
> > this - add the COROSYNC-MIB.txt to EXTRA_DIST in the conf dir, or
> > alternately (less preferred) add to top level Makefile.am
> >
> > Really great work!  just a few issues to sort out and we should be good
> > for merge.
> >
>