[kvm-devel] [RFC PATCH] virtio: change config to guest endian.
Hollis Blanchard
hollisb at us.ibm.com
Tue Apr 22 13:29:14 PDT 2008
On Tuesday 22 April 2008 09:31:35 Rusty Russell wrote:
> On Tuesday 22 April 2008 21:22:48 Avi Kivity wrote:
> > > The virtio config space was originally chosen to be little-endian,
> > > because we thought the config might be part of the PCI config space
> > > for virtio_pci. It's actually a separate mmio region, so that
> > > argument holds little water; as only x86 is currently using the virtio
> > > mechanism, we can change this (but must do so now, before the
> > > impending s390 and ppc merges).
> >
> > This will probably annoy Hollis which has guests that can go both ways.
>
> Yes, I discussed this with Hollis. But the virtio rings themselves already
> have this issue: we don't do any endian conversion on them and assume
> they're "our" endian in the guest.
>
> We may still regret not doing *everything* little-endian, but this doesn't
> make it worse.
Hmm, why *don't* we just do everything LE, including the ring?
--
Hollis Blanchard
IBM Linux Technology Center
More information about the Virtualization
mailing list