[PATCH 1/4] virtio: wean net driver off NETDEV_TX_BUSY

Herbert Xu herbert at gondor.apana.org.au
Mon Apr 28 22:06:16 PDT 2008


On Tue, Apr 29, 2008 at 01:16:05AM +1000, Rusty Russell wrote:
>
> +	/* If we has a buffer left over from last time, send it now. */
> +	if (vi->last_xmit_skb) {
> +		if (xmit_skb(vi, vi->last_xmit_skb) != 0) {
> +			/* Drop this skb: we only queue one. */
> +			kfree_skb(skb);
> +			goto stop_queue;

We should increment the drop counter here.

Otherwise these patches all look good to me.

Acked-by: Herbert Xu <herbert at gondor.apana.org.au>

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert at gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


More information about the Virtualization mailing list