[Bridge] Re: [PATCH] fix oops when mangling and brouting and tcpdumping packets

Bart De Schuymer bdschuym at pandora.be
Tue Aug 24 13:35:10 PDT 2004


On Tuesday 24 August 2004 20:38, Stephen Hemminger wrote:
> How about this, it is basically Bart's patch with:
> 	* some more cleanups to handle_bridge
> 	* removing extra rcu_read_lock (already done in netif_receive_skb)
> 	* pass bridge port to hook since already dereferenced in handle_bridge

Looks good.
I'm not sure if the rcu_dereference() is needed, however. Can the bridge port 
be removed while a packet is being processed? I thought the rcu_read_lock() 
protects against that (del_nbp() does call_rcu(&p->rcu, destroy_nbp_rcu)).

cheers,
Bart




More information about the Bridge mailing list