[Bridge] Re: [PATCH] TSO fix in br_dev_queue_push_xmit

[Stephen Hemminger]

On Wed, 21 Sep 2005 15:53:06 +0300
Vlad Drukker <vlad at storewiz.com> wrote:

> Hi,
> 
> I see you all agree to apply :)
> 
> Stephen, repost of this patch to proper places below.
> 
> Thank you Henrik for clarification of bridge standard.
> However, silent drop of locally generated packets on 99% idle carrier
> grade machine looks like a hardware problem.
> 
> David, don't you think that having software packet drop counters is a
> bad idea? I thought, software drop counters are there to help identify
> hardware problems or lack of resources. In this case, tcp stack produced
> output that just gone. TSO is there over years and no one even noticed
> given TSO/bridge conflict mainly because there is no stats. (IMHO)
> Let's blame standards, right? 
> 

Patch is fine.

Putting in a counter would be good, but there is no good
structure to put it in.  The bridge device (br0) counters
make sense for locally generated packets, the network devices
(ethX) forwarding packets are under control of the other device
driver.

There is a whole bridge MIB defined in the standard, but adding
it would be a lot of work, and not sure if anyone would care.