[Bridge] [PATCH] fix 802.3ad multicast

Vlad Drukker vlad at storewiz.com
Sun Apr 9 07:42:54 PDT 2006


On Fri, 2006-04-07 at 16:59 -0700, Stephen Hemminger wrote:
> On Thu, 06 Apr 2006 19:15:06 +0300
> Vlad Drukker <vlad at storewiz.com> wrote:
> 
> > Hi Stephen,
> > 
> > there was a bug in bridging bonds.
> > multicast packets needed for 802.3ad netif_carrier_ok() were dropped.
> > attached patch works for me.
> > 
> > Cheers,
> > Vlad.
> > 
> > 
> > 
> 
> Making a bonding specific hack like this seems wrong. The
> port could also be disabled during shutdown (for RCU removal),
> and in that case we need to drop the packet.
> 
> There must be a better solution.
> 

you probably right, 
skb_bond() looks like a proper place for this, because
netif_receive_skb() needs to call ETH_P_SLOW hadler instead of
hadle_bridge hook.

the fix is moving to linux-net . 





More information about the Bridge mailing list