[Bridge] [PATCH] bridge: random extra bytes on STP TCN packet

Stephen Hemminger shemminger at osdl.org
Tue Sep 5 09:59:07 PDT 2006


We seem to send 3 extra bytes in a TCN, which will be whatever happens
to be on the stack. Thanks to Aji_Srinivas at emc.com for seeing.

Signed-off-by: Stephen Hemminger <shemminger at osdl.org>

diff -Naur a/net/bridge/br_stp_bpdu.c b/net/bridge/br_stp_bpdu.c
--- a/net/bridge/br_stp_bpdu.c	2006-09-03 23:40:08.000000000 +0530
+++ b/net/bridge/br_stp_bpdu.c	2006-09-03 23:40:33.000000000 +0530
@@ -121,7 +121,7 @@
 	buf[1] = 0;
 	buf[2] = 0;
 	buf[3] = BPDU_TYPE_TCN;
-	br_send_bpdu(p, buf, 7);
+	br_send_bpdu(p, buf, 4);
 }
 
 /*




More information about the Bridge mailing list