[Bridge] [PATCH] net/bridge: use the maximum hard_header_len of ports for bridging device

David Miller davem at davemloft.net
Mon Mar 23 15:47:51 PDT 2009


From: Stephen Hemminger <shemminger at linux-foundation.org>
Date: Mon, 23 Mar 2009 15:45:17 -0700

> So you dynamically compute the additional space but if the space was
> an awkward size, could it cause driver to breaks alignment assumptions?

Yes, you'd need to 16-byte align or something like that.

> And you didn't fixup the skb that is about to gag in the skb to make
> more space, so transmitting device driver (gfar) is going to overwrite or die.

This particular instance will do the headroom reallocation,
that's unavoidable during the size transition event.

The headroom checks can't ever be removed, but we won't hit
them in the fast path after the adjustment is made by my
patch.


More information about the Bridge mailing list