[Bridge] [PATCH] net/bridge: use the maximum hard_header_len of ports for bridging device
leoli at freescale.com
Wed Mar 25 01:38:38 PDT 2009
On Wed, Mar 25, 2009 at 3:06 PM, David Miller <davem at davemloft.net> wrote:
> From: Li Yang <leoli at freescale.com>
> Date: Wed, 25 Mar 2009 15:05:20 +0800
>> On Wed, Mar 25, 2009 at 2:40 PM, David Miller <davem at davemloft.net> wrote:
>> > From: Li Yang <leoli at freescale.com>
>> > Date: Fri, 20 Mar 2009 17:04:29 +0800
>> >> The bridging device used a constant hard_header_len. This will cause
>> >> headroom shortage for ports with additional hardware header. The patch
>> >> makes bridging device to use the maximum value of all ports.
>> >> Signed-off-by: Li Yang <leoli at freescale.com>
>> > Your driver must be able to cope with any amount of
>> > available headroom, no matter what hacks we put into
>> > the bridging layer.
>> > Please fix your driver, I'm not applying this patch.
>> Ok. But it's not good to reallocate every packet generated locally.
>> Why not take this patch too?
> Because as Stephen showed it didn't handle all cases.
> Look at the patch I posted, that's the way to go.
Patch coming right away. However I have some comment about your way.
The choice is yours.
More information about the Bridge