[Bridge] [PATCH] bridge: netfilter: fix a memory leak

Changli Gao xiaosuo at gmail.com
Sun Aug 22 21:40:28 PDT 2010


On Mon, Aug 23, 2010 at 12:36 PM, David Miller <davem at davemloft.net> wrote:
> From: Changli Gao <xiaosuo at gmail.com>
> Date: Fri, 20 Aug 2010 13:03:16 +0800
>
>> nf_bridge_alloc() always reset the skb->nf_bridge, so we should always
>> put the old one. skb->nf_bridge->use is initialized in nf_bridge_alloc(),
>> so we don't need to initialize it again.
>>
>> Signed-off-by: Changli Gao <xiaosuo at gmail.com>
>
> We just memcpy()'d 'nf_bridge' to 'tmp', that why the ->use count is
> going to be something other than '1'.  It now has the ->use count that
> 'nf_bridge' did.
>
> And that is why we must explicitly do atomic_set() on 'tmp'.
>

Oops, thanks. I'll post a update.


-- 
Regards,
Changli Gao(xiaosuo at gmail.com)


More information about the Bridge mailing list