[Bridge] Re :Re: Re :Re: Re :Re: Bridging LACP (802.3ad) frames not working

[Jean-Michel Hautbois]

2010/1/20 Stephen Hemminger <shemminger at linux-foundation.org>:
> On Wed, 20 Jan 2010 18:31:06 +0200
> Yavetskiy Yuriy <yavetskiy at kpi.ua> wrote:
>
>> Hello.
>>
>> I solve my problem without ebtables.
>> Just add to net/bridge/br_input.c next strings (with +):
>>
>>         if (unlikely(is_link_local(dest))) {
>>                 /* Pause frames shouldn't be passed up by driver anyway */
>>                 if (skb->protocol == htons(ETH_P_PAUSE))
>>                         goto drop;
>>
>> +                /* Don't touch SLOW frames (LACP, etc.) */
>> +               if (skb->protocol == htons(ETH_P_SLOW))
>> +                        goto forward;
>>
>
> Fine for your case, but in general it is wrong to forward these
> frames.

I agree, and once again, I wish we could add a flag that enables
forwarding these frames.
A flag that would be off by default.
I don't understand why this could be problematic...

Regards,
JM