[Bridge] [PATCH] bridge: push blocking slaves to forwarding when turning stp off

Vitalii Demianets vitas at nppfactor.kiev.ua
Tue Dec 20 10:59:11 UTC 2011


Hello, Stephen!
I can not understand your silence.
There are issues fixed by the patch in question. For example, if the interface 
is left in blocking state after stp was turned off, that state is not 
stable - it can flip to forwarding state in unpredictable times, e.g. when 
_any other_ slave of the bridge goes up or down. Do you think user wants 
exactly that unpredictable state change?
Also, the code in question in function br_stp_stop(), namely 
br_port_state_selection(br) call, does exactly nothing except wasting cpu 
cycles. Isn't it worth fixing?

-- 
Vitalii Demianets


More information about the Bridge mailing list