[Bridge] [PATCH] bridge: master device stuck in no-carrier state forever when in user-stp mode
shemminger at vyatta.com
Wed Nov 30 00:06:56 UTC 2011
On Tue, 29 Nov 2011 18:54:33 -0500 (EST)
David Miller <davem at davemloft.net> wrote:
> From: Vitalii Demianets <vitas at nppfactor.kiev.ua>
> Date: Fri, 25 Nov 2011 12:16:37 +0200
> > When in user-stp mode, bridge master do not follow state of its slaves, so
> > after the following sequence of events it can stuck forever in no-carrier
> > state:
> > 1) turn stp off
> > 2) put all slaves down - master device will follow their state and also go in
> > no-carrier state
> > 3) turn stp on with bridge-stp script returning 0 (go to the user-stp mode)
> > Now bridge master won't follow slaves' state and will never reach running
> > state.
> > This patch solves the problem by making user-stp and kernel-stp behavior
> > similar regarding master following slaves' states.
> > Signed-off-by: Vitalii Demianets <vitas at nppfactor.kiev.ua>
> Stephen, please review this patch, thanks.
Agree that it is a problem, but want to fix the code up. The logic
can be done slightly cleaner.
More information about the Bridge