[Bridge] [PATCH] net, bridge: print log message after state changed

Fritz, Wolfgang Wolfgang.Fritz at keymile.com
Mon Nov 14 07:13:40 UTC 2011


Am Montag, den 14.11.2011, 00:37 -0500 schrieb David Miller:
> From: Holger Brunck <holger.brunck at keymile.com>
> Date: Thu, 10 Nov 2011 17:18:54 +0100
> 
> > From: Wolfgang Fritz <wolfgang.fritz at keymile.com>
> > 
> > Function br_log_state writes log message "... entering XXXX state" so it
> > should be called after the state has changed and not before.
> > 
> > Signed-off-by: Wolfgang Fritz <wolfgang.fritz at keymile.com>
> > Signed-off-by: Holger Brunck <holger.brunck at keymile.com>
> 
> "entering" can roughly mean "about to enter"
> 

Exactly.

> The message is therefore appropriately timed as far as I'm concerned.
> 

It's not.

Please test: create a bridge with STP disabled, add an interface to the
bridge and set that interface down. You get the message "... entering
forwarding state". That's wrong because it's "about to enter" disabled
state some lines later.

All other (4) calls to br_log_state are located after the state change,
see for example br_stp_enable_port() just some lines above the patch.

Regards,
Wolfgang 


> I'm not applying this patch.
> 
-- 
"I love deadlines. I like the whooshing sound they make as they fly by"
(Douglas Adams)
=======================================================================
KEYMILE GmbH       mailto:wolfgang.fritz at keymile.com
Wolfgang Fritz     Phone: +49 (0)511 6747-692
Wohlenbergstr. 3   Fax:   +49 (0)511 6747-777
D-30179 Hannover   http://www.keymile.com

Managing Directors: Björn Claaßen, Dipl.-Kfm. Andreas Gebauer
Legal structure: GmbH, Registered office: Hanover, HRB 61069 
Local court Hanover, VAT-Reg.-No.: DE 812282795, 
WEEE-Reg.-No.: DE 59336750
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/bridge/attachments/20111114/77e256e9/attachment-0001.html>


More information about the Bridge mailing list