[Bridge] Query on Sapnning tree implementation from standard point of view

Vitalii Demianets vitas at nppfactor.kiev.ua
Tue Jun 19 08:16:50 UTC 2012


On Tuesday 19 June 2012 10:54:13 Sasikanth babu wrote:
> >
> > Don't you think that including this check in Linux bridging code is
> > worthwhile?
> >
> >   Are you talking about this check (in function br_stp_rcv)?
>
>                 if (bpdu.message_age > bpdu.max_age) {
>                         if (net_ratelimit())
>                                 br_notice(p->br,
>                                           "port %u config from %pM"
>                                           " (message_age %ul > max_age
> %ul)\n",
>                                           p->port_no,
>                                           eth_hdr(skb)->h_source,
>                                           bpdu.message_age, bpdu.max_age);
>                         goto out;
>                 }
>

Oh, yes, thank you for pointing that out. I was clearly looking at the 
outdated code.

-- 
With Best Regards,
Vitalii Demianets


More information about the Bridge mailing list