[Bridge] [PATCH v2 net-next 2/6] bridge: make flags sysfs interface a little bit more extensible

Stephen Hemminger stephen at networkplumber.org
Fri Apr 19 20:55:33 UTC 2013


On Fri, 19 Apr 2013 16:52:46 -0400
Vlad Yasevich <vyasevic at redhat.com> wrote:

> +
> +static int store_flag(struct net_bridge_port *p, unsigned long v,
> +		     unsigned long mask)
> +{
> +	unsigned long flags = p->flags;
> +
> +	if (v)
> +		flags |= mask;
> +	else
> +		flags &= ~mask;
> +
> +	if (flags != p->flags) {
> +		p->flags = flags;
> +		br_ifinfo_notify(RTM_NEWLINK, p);
> +	}
> +	return 0;
> +}

I don't want to allow arbitrary flag stores (and shows).
It exposes kernel bits to user space and creates an unintended ABI.


More information about the Bridge mailing list