[Bridge] [PATCHv2] bridge: disable snooping if there is no querier

David Miller davem at davemloft.net
Tue Jul 30 23:10:35 UTC 2013


From: Linus Lüssing <linus.luessing at web.de>
Date: Thu, 25 Jul 2013 15:56:20 +0200

> +	atomic64_t			multicast_querier_delay_time;

Please don't use an atomic64_t here, it's pointless.

You're only doing set and read operations on it, there's absolutely
nothing atomic about that.

You have to make sure that the top-level operations that use this
new value use an appropriate amount of locking on the higher level
objects.


More information about the Bridge mailing list