[Bridge] [PATCH net] bridge: Don't include NDA_VLAN for FDB entries with vid 0

David Miller davem at davemloft.net
Thu Jul 31 19:19:23 UTC 2014


From: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp>
Date: Wed, 30 Jul 2014 13:31:51 +0900

> An FDB entry with vlan_id 0 doesn't mean it is used in vlan 0, but used when
> vlan_filtering is disabled.
> 
> There is inconsistency around NDA_VLAN whose payload is 0 - even if we add
> an entry by RTM_NEWNEIGH without any NDA_VLAN, and even though adding an
> entry with NDA_VLAN 0 is prohibited, we get an entry with NDA_VLAN 0 by
> RTM_GETNEIGH.
> 
> Dumping an FDB entry with vlan_id 0 shouldn't include NDA_VLAN.
> 
> Signed-off-by: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp>

This is clearly the right thing to do, since upon FDB addition we reject
NDA_VLAN attributes with value zero.

Applied, thanks.


More information about the Bridge mailing list